Ticket #17 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

0016783: [Core] is_unappropriate parameter: version + error control

Reported by: admin Owned by: robert
Priority: minor Milestone: MediaMosa 2.1
Component: Core Version:
Keywords: Cc:
MoSCoW: Could Have Estimated time after impact analysis:
Related to project: none Tested: yes
Accepted: yes Estimated Hours:

Description

requested is a versioned REST call to introduce new syntax for is_unappropiate
Options now are:
is_unappropriate
is_unappropiate
is_inappropriate


 http://mantis.kennisnet.nl/view.php?id=16783
0016783: [Core] is_unappropriate parameter: version + foutafh.

Aanvulling op issue: 16709 (1.5.2)
 http://mantis.kennisnet.nl/view.php?id=16709 []

Arjen:
Wat nu (versie 1.5.2) werkt is:

is_unappropriate
is_unappropiate
is_inappropriate

In alle gevallen zal intern het veld is_unappropiate worden bijgewerkt. De
output (bij /asset/id [GET]) is nog steeds unappropiate, om geen bestaande
calls te breken.

sitestep:
Ik stel voor dat we in een volgende versie (1.6?) een versienummer in de
rest call introduceren en nieuwe asset syntax gaan introduceren. Nieuw
ticket?


Michiel:

de 3 spellingsvarianten werken op de voorspelde manier.
een request waarin 1 foute parameter en 3 goede parameter wordt opgegeven
bijvoorbeeld

[post] /asset/2uv5o37QRZ99anab5I0wbTU2
[params]
is_inappropriates=false&is_private=false&user_id=SURFgroepen.Kirstenveelo&is_app_admin=true

krijgt nu een 715-foutmelding. Dit zou bestaande applicaties kunnen
breken, omdat foutieve parameters tot nu toe genegeerd werden.

Maar een request als
[params]
is_private=false&user_id=SURFgroepen.Kirstenveelo&is_app_admin=true&testparam=23&is_unappropriate=true

met 1 foute (testparam) en 4 goede parameters gaat wel goed (601-sucess)

Het weglaten van de laatste
[params] [params]
is_private=false&user_id=SURFgroepen.Kirstenveelo&is_app_admin=true&testparam=23
laat de call weer wel lukken.

Issue van maken?

Change History

Changed 4 years ago by Frans

  • priority changed from major to minor
  • type changed from defect to enhancement
  • component set to Core
  • milestone changed from MediaMosa X.X to MediaMosa 1.7

Changed 4 years ago by MC-arjen

  • owner set to marek
  • status changed from new to assigned
  • related_to set to none

Changed 3 years ago by Frans

  • milestone changed from MediaMosa 1.7 to MediaMosa 2.1

Moved to MediaMosa 2.1

Changed 3 years ago by Frans

  • moscow set to Could Have

Changed 3 years ago by robert

  • status changed from assigned to closed
  • resolution set to worksforme

In 2.1 this behavior has been changed/fixed;

We use 'is_unappropriate' in the database. (no effect for EUA's)
We use 'is_unappropriate' in CQL for searching.
We return 'is_unappropriate' and 'is_unappropiate' in the asset output where we consider the misspelled 'is_unappropiate' as deprecated.
We accept 'is_unappropriate' and 'is_inappropriate' as input on an asset update.

I suggest to close this ticket and make a new one if the 2.1 solution is breaking EUA's.

Changed 3 years ago by robert

  • status changed from closed to reopened
  • resolution worksforme deleted

Changed 3 years ago by robert

  • owner changed from marek to robert
  • status changed from reopened to assigned

Changed 3 years ago by robert

  • status changed from assigned to closed
  • resolution set to fixed

Changed 3 years ago by Frans

  • tested set to yes
  • accepted changed from no to yes

We see the results in the XML data:

<is_unappropiate>FALSE</is_unappropiate>

and <is_unappropriate>FALSE</is_unappropriate>

BTW: those lines are not together, but it'll do.

     <asset_id>1f1yNtISjfxmMQzzTrsl0CL9</asset_id>
      <app_id>7</app_id>
      <provider_id></provider_id>
      <owner_id>admin</owner_id>
      <group_id></group_id>
      <videotimestamp>2009-11-18 23:30:02</videotimestamp>
      <videotimestampmodified>2009-11-18 23:34:00</videotimestampmodified>
      <play_restriction_start></play_restriction_start>
      <play_restriction_end></play_restriction_end>
      <reference_id></reference_id>
      <isprivate>FALSE</isprivate>
      <mediafile_duration>00:02:10.0</mediafile_duration>
      <mediafile_container_type>asf</mediafile_container_type>
      <is_unappropriate>FALSE</is_unappropriate>
      <is_external>FALSE</is_external>
      <is_empty_asset>FALSE</is_empty_asset>
      <viewed>9</viewed>
      <played>4</played>
      <is_protected>FALSE</is_protected>
      <is_unappropiate>FALSE</is_unappropiate>

Note: See TracTickets for help on using tickets.