0016576: 6 [Core] VPcore heeft geen mogelijkheid om collecties op 'inactief' te zetten

[admin]

---

0016576: 6 [Core] VPcore heeft geen mogelijkheid om collecties op 'inactief' te zetten
 http://mantis.kennisnet.nl/view.php?id=16576

Dit zou de beheerders de mogelijkheid moeten geven om
bepaalde collecties dicht te gooien.

[admin]

(0026509)
schok01 (reporter)
2009-01-20 16:09

Bedoeling van SURFmedia is inderdaad 'is_inappropriate'.
Collectie mag niet meer tevoorschijn komen in zoekresultaten, behalve vanuit de beheeromgeving (app_admin).

Collectie moet ook verdwijnen uit OAI.
(0026491)
klop01 (manager)
2009-01-20 13:46

Een aantal vragen:

Is "dicht gooien": "nergens meer tonen (ala is_unapropiate bij asset) " of is dit een costructie waarbij de collectie voor verdere wijzigingen wordt gesloten.?

En mag de eigenaar de collectie nog wel zien/wijzigen? Of alleen de app_admin?

Heeft dit veld relatie tot OAI?

Het veld toevoegen is eenvoudig (2 uur, incl webservice doc en unit test),

De rest hangt af van de antwoorden...

[marek]

unit test test #16576

[Michiel.Schok]

Setting unappropriate is great. Finding the collection (or not) as a user or as an admin is also great.

But when we perform a
[get] /collection/{id} on an unappropriate collection, we get an 1800 response:

<request_result_description>Action is not allowed, not authorized</request_result_description>
<request_result_id>1800</request_result_id>

when we perform a [get] /asset/{id} on an unappropriate asset, we get an 1905 response:

<request_result_description>This video is flagged  unappropriate</request_result_description>
<request_result_id>1905</request_result_id>

We would like to see a similar descriptive error, why the collection is not available.

[forgacs]

Ready. It is on the SVN.

[MC-arjen]

1.6.4: [get] /collection/{id} now also gives an 1905.

[Frans]

Unable to set "is_unappropriate=true" on a collection to test this issue.

Using a post /collection/EGkDTcO1g3Ia32O4in4yyTGM
Post parameters: is_unappropriate=true&user_id=SURFgroepen.frans

Will result in a

<?xml version="1.0"?>
<response>
  <header>
    <item_count>0</item_count>
    <request_process_time>0.0089</request_process_time>
    <request_query_count>15</request_query_count>
    <request_result>error</request_result>
    <request_result_description>Insufficient paramaters given, changes not saved</request_result_description>
    <request_result_id>715</request_result_id>
    <request_uri>[POST] collection/EGkDTcO1g3Ia32O4in4yyTGM</request_uri>
    <vpx_version>1.6.4</vpx_version>
  </header>
  <items/>
</response>

[Michiel.Schok]

The unappropriate flag can only be changed when is_app_admin=true.

[Frans]

AHA!
POST PARAMETERS: is_unappropriate=true&user_id=SURFgroepen.frans&is_app_admin=true

Result:

<?xml version="1.0"?>
<response>
  <header>
    <item_count>0</item_count>
    <request_process_time>0.0122</request_process_time>
    <request_query_count>14</request_query_count>
    <request_result>error</request_result>
    <request_result_description>This video is flagged unappropriate</request_result_description>
    <request_result_id>1905</request_result_id>
    <request_uri>[GET] collection/EGkDTcO1g3Ia32O4in4yyTGM</request_uri>
    <vpx_version>1.6.4</vpx_version>
  </header>
  <items/>
</response>

We see the 1905 result code.
It would be nicer when the description says

    <request_result_description>This collection is flagged unappropriate</request_result_description>

But will settle for now.

[Michiel.Schok]

I guess we don't want different result descriptions for 1905, depending on whether it's an /asset or a /collection call.
Maybe change description to 'This item is flagged unappropriate' so it's usable for assets, collections and whatever we add in the future?